Skip to content

fix: reject GEOMETRY and TIMESTAMPTZ in STRUCT #44937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2025
Merged

fix: reject GEOMETRY and TIMESTAMPTZ in STRUCT #44937

merged 2 commits into from
Oct 20, 2025

Conversation

@SpadeA-Tang
Copy link
Contributor

issue: #44930

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Oct 17, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 17, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp

If you have any questions or requests, please contact @zhikunyao.

zhengbuqian
zhengbuqian reviewed Oct 17, 2025
View reviewed changes
Copy link
Collaborator

@zhengbuqian zhengbuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@SpadeA-Tang SpadeA-Tang mentioned this pull request Oct 17, 2025
Merged
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SpadeA-Tang, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.00%. Comparing base (754997a) to head (754997a).
⚠️ Report is 17 commits behind head on master.

⚠️ Current head 754997a differs from pull request most recent head 7a10d7c

Please upload reports for the commit 7a10d7c to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #44937   +/-   ##
=======================================
  Coverage   77.00%   77.00%           
=======================================
  Files        1831     1831           
  Lines      285065   285065           
=======================================
  Hits       219506   219506           
  Misses      58400    58400           
  Partials     7159     7159
Components Coverage Δ
Client 78.03% <0.00%> (ø)
Core 83.95% <0.00%> (ø)
Go 75.10% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2025

@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@SpadeA-Tang
Copy link
Contributor Author

/ci-rerun-ut-go

@SpadeA-Tang
Copy link
Contributor Author

/run-cpu-e2e

@SpadeA-Tang
Copy link
Contributor Author

/ci-rerun-ut-integration

@zhagnlu
Copy link
Contributor

zhagnlu commented Oct 20, 2025

/lgtm

@SpadeA-Tang
Copy link
Contributor Author

/refresh-label

sre-ci-robot pushed a commit that referenced this pull request Oct 20, 2025
@SpadeA-Tang
fix: reject GEOMETRY and TIMESTAMPTZ in STRUCT [2.6] (#44938)
94c3f11 
issue: #44930
pr: #44937

Signed-off-by: SpadeA <[email protected]>
@mergify mergify bot added the ci-passed label Oct 20, 2025
@sre-ci-robot sre-ci-robot merged commit 34f54da into milvus-io:master Oct 20, 2025
12 of 14 checks passed
@SpadeA-Tang SpadeA-Tang mentioned this pull request Oct 22, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhengbuqian zhengbuqian zhengbuqian approved these changes

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@zhagnlu zhagnlu

@zhengbuqian zhengbuqian

Labels

approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SpadeA-Tang @sre-ci-robot @zhagnlu @zhengbuqian